Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape special characters in TwiML attribute values #501

Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix: escape special characters in TwiML attribute values #501

merged 1 commit into from
Nov 14, 2019

Conversation

childish-sambino
Copy link
Contributor

Fixes #500

@childish-sambino childish-sambino merged commit c6758fb into master Nov 14, 2019
@childish-sambino childish-sambino deleted the escape-twiml branch November 14, 2019 18:08
@oliverhr
Copy link

oliverhr commented Nov 25, 2019 •
edited
Loading

When this change is going to be released? since it fix a breaking change, causing:
#500

Error - 12100
Document parse failure
Twilio was unable to parse the provided XML Document.

@childish-sambino
Copy link
Contributor Author

@oliverhr Had to schedule around holidays. Next release is set for 2019-12-04.

@oliverhr
Copy link

@childish-sambino glad to hear that, thank you.

@snyk-bot snyk-bot mentioned this pull request Jan 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ampersands not being converted to & when they are values of attributes
3 participants
@childish-sambino @oliverhr @thinkingserious